Skip to content

[SPARK-10469][DOC] Try and document the three options#8638

Closed
holdenk wants to merge 2 commits into
apache:masterfrom
holdenk:SPARK-10469-document-tungsten-sort
Closed

[SPARK-10469][DOC] Try and document the three options#8638
holdenk wants to merge 2 commits into
apache:masterfrom
holdenk:SPARK-10469-document-tungsten-sort

Conversation

@holdenk

@holdenk holdenk commented Sep 7, 2015

Copy link
Copy Markdown
Contributor

From JIRA:
Add documentation for tungsten-sort.
From the mailing list "I saw a new "spark.shuffle.manager=tungsten-sort" implemented in
https://issues.apache.org/jira/browse/SPARK-7081, but it can't be found its
corresponding description in
http://people.apache.org/~pwendell/spark-releases/spark-1.5.0-rc3-docs/configuration.html(Currenlty
there are only 'sort' and 'hash' two options)."

@holdenk holdenk changed the title [SPARK-10469] Try and document the three options [SPARK-10469][DOC] Try and document the three options Sep 7, 2015
@SparkQA

SparkQA commented Sep 7, 2015

Copy link
Copy Markdown

Test build #42084 has finished for PR 8638 at commit 4978681.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Comment thread docs/configuration.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits: "to the sort-based". Does this need qualification as being experimental, and available from 1.5 onward?

@SparkQA

SparkQA commented Sep 7, 2015

Copy link
Copy Markdown

Test build #42088 has finished for PR 8638 at commit 0aada24.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14

Copy link
Copy Markdown
Contributor

LGTM, merging into master 1.5.

asfgit pushed a commit that referenced this pull request Sep 10, 2015
From JIRA:
Add documentation for tungsten-sort.
From the mailing list "I saw a new "spark.shuffle.manager=tungsten-sort" implemented in
https://issues.apache.org/jira/browse/SPARK-7081, but it can't be found its
corresponding description in
http://people.apache.org/~pwendell/spark-releases/spark-1.5.0-rc3-docs/configuration.html(Currenlty
there are only 'sort' and 'hash' two options)."

Author: Holden Karau <holden@pigscanfly.ca>

Closes #8638 from holdenk/SPARK-10469-document-tungsten-sort.

(cherry picked from commit a76bde9)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in a76bde9 Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants